Pass -DPYTHON_EXECUTABLE to cmake#25
Merged
Merged
Conversation
This is important when using a virtualenv without activating it.
minamikik
added a commit
to minamikik/ndi-python
that referenced
this pull request
Feb 23, 2024
Owner
|
Thank you for your PR! Sorry for the long wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building ndi-python with virtualenv without activating it, cmake tries to find system-installed python:
This is not good because the version of found one might be different than virtualenv's one.
Therefore, cmake's
PYTHON_EXECUTABLEvariable should be explicitly set bysetup.py.